Reviewed: https://reviews.mahara.org/8117 Committed: https://git.mahara.org/mahara/mahara/commit/3f4bba464cde8424d77d2de11d0bf7803840041c Submitter: Robert Lyon ([email protected]) Branch: 17.10_STABLE
commit 3f4bba464cde8424d77d2de11d0bf7803840041c Author: Robert Lyon <[email protected]> Date: Mon Oct 9 14:29:55 2017 +1300 Bug 1722132: Video mimetype not set correctly due to fetch by assoc Rather than fetching by array now that we have multiple extensions using the 'video/mp4' mimetype. This would cause problems for older sites where the file was correctly saved as 'video' artefacttype but where the fetching from db of the mimetypes to compare would associate a different extension to 'video/mp4', eg 'm4v'. This also meant that videos uploaded after commit a5cf7d59ebbd17193efaa38661eafe7b370095ee could end up being saved as atefacttype 'file' rather than 'video' This patch fetches mimetypes as array and tidies things up for video behatnotneeded Change-Id: I53dc2d5ddb573d630f1de408cc9c027e488cd99e Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit e978112e5eb686fb17f02b7df3ea65783053dfd9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1722132 Title: When artefact type is set to 'video' in the database, Undefined index: video/mp4 error is shown Status in Mahara: Fix Committed Bug description: When artefact type is set to 'video' in the database, "Undefined index: video/mp4" error is shown but when an artefact type is set to 'file' there is no error. $validtypes = self::video_mime_types(); does not have mp4 From Robert: 1) why are we now saving mp4 as 'file' rather than 'video' 2) why does $validtypes not have 'video/mp4' as an option To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1722132/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
