Reviewed: https://reviews.mahara.org/8137 Committed: https://git.mahara.org/mahara/mahara/commit/b737ffe83f4ebf9a108b9aecda2639372b74a8a2 Submitter: Robert Lyon ([email protected]) Branch: master
commit b737ffe83f4ebf9a108b9aecda2639372b74a8a2 Author: Robert Lyon <[email protected]> Date: Fri Oct 13 10:50:01 2017 +1300 Bug 1720912: Drop triggers correctly with drop_elasticsearch_triggers() behatnotneeded Change-Id: I439d1161e2d3ae12920ae24bba8af47c62a7ce07 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1720912 Title: Better way to disable elasticsearch triggers during upgrade Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: Currently if we want to upgrade some of our tables like view, artefact, view_atefact they can take up lots of time/memory if elasticsearch is being used as that has triggers that add info to the search_elasticsearch_queue table as well. And with elasticsearch queue triggers it checks the queue for the item about to be added and only add it if not already there. So if the number of rows to update is 100,000+ each row add/check is slightly slower than the last. Instead we should just drop the triggers when we do the change and add them back in after and to make this easier we should have a drop_elasticsearch_trigger($table); and create_elasticsearch_trigger($table); pair that we can wrap around specific updates that will do the check to see if elasticsearch is being used and do the correct dropping/adding of triggers To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1720912/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
