Reviewed: https://reviews.mahara.org/8549 Committed: https://git.mahara.org/mahara/mahara/commit/a1970027b0c5a0e01aad1f223e6f3f276237d8db Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit a1970027b0c5a0e01aad1f223e6f3f276237d8db Author: Robert Lyon <[email protected]> Date: Thu Mar 1 07:16:52 2018 +1300 Bug 1752389: Undefined property: stdClass::$name on upgrade This is when plugins are out of sync and the plugin doesn't have $config->name defined We should fall back to the plugin path as the name behatnotneeded Change-Id: I6bb64e785c0d3e12d77b681a34379f70865eaa28 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1752389 Title: Warning Undefined property: stdClass::$name on upgrade Status in Mahara: Fix Committed Bug description: We have a mechanism where is the database information about a plugin is newer than the plugin's file information we: (in production mode) warn the user before upgrade (not in production mode) display the problem on admin dashboard after upgrade But there is a problem if the plugin doesn't set a display name or a fallback $config->name We need to allow the plugin to display it's path name so as to be slightly helpful. To test: Have a fully upgraded site then: 1) Set the config version back one day, eg: UPDATE config SET value = value::int - 100 WHERE field = 'version'; 2) Update a plugin's installed value forward one day, eg: UPDATE artefact_installed SET version = version::int + 100 WHERE name = 'resume'; UPDATE search_installed SET version = version::int + 100 WHERE name = 'elasticsearch'; Before patch - you should see warning when not in production mode To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1752389/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
