Reviewed: https://reviews.mahara.org/8713 Committed: https://git.mahara.org/mahara/mahara/commit/1932d334e0f02ed31c99aa60ca498801bc04cbb3 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit 1932d334e0f02ed31c99aa60ca498801bc04cbb3 Author: Robert Lyon <[email protected]> Date: Mon Mar 26 10:35:42 2018 +1300 Bug 1758757: setup_links() expected to be a reference, value given error We used call_user_func() but i think we need to use call_user_func_array() for this behatnotneeded Change-Id: I94dad0b59be8bab7ac6b2e1c45a6968ac4ece9fa Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1758757 Title: Leap2A export warnings on comment/annotation Status in Mahara: Fix Committed Bug description: On doing an export in PHP 7.0/7.1 I see these warnings [WAR] 4a (export/leap/lib.php:406) Parameter 1 to LeapExportElementComment::setup_links() expected to be a reference, value given, referer: http://testing/export/index.php [WAR] 4a (export/leap/lib.php:406) Parameter 1 to LeapExportElementAnnotation::setup_links() expected to be a reference, value given, referer: http://testing/export/index.php In the Mahara code it says: "You must explicitly pass variables by reference when calling call_user_func, ..." But in PHP manual itself it says "Note that the parameters for call_user_func() are not passed by reference." So there is something not quite right here To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1758757/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
