Reviewed: https://reviews.mahara.org/9001 Committed: https://git.mahara.org/mahara/mahara/commit/118984ac6d5d0bae3500fd1c739d5730c4e34d6a Submitter: Cecilia Vela Gurovic ([email protected]) Branch: 17.04_STABLE
commit 118984ac6d5d0bae3500fd1c739d5730c4e34d6a Author: Cecilia Vela Gurovic <[email protected]> Date: Tue Jul 10 10:21:34 2018 +1200 Bug 1778451: Show legend in charts Use correct variable in template when creating the legend for charts. In Chart.js legendTemplate uses var 'datasets' or 'segments' depending on the type of charts type Doughnut/PolarArea/Pie use segments type Line/Radar/Bar use datasets We have to check which one is defined in the Chart object before modifying the legend template behatnotneeded Change-Id: I3185616d5ffde2378c092c59c78c01503d01e6ae -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1778451 Title: user statistics sendjasonrequest error Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Bug description: in admin/users/statistics.php, just loading the page will make a few errors show in the browsers console. sendjsonrequest() callback failed: ReferenceError columnNumber: 133 fileName: "http://maharatest/js/chartjs/Chart.min.js?v=8242 line 10 > Function" lineNumber: 3 message: "datasets is not defined" stack: "anonymous@http://maharatest/js/chartjs/Chart.min.js?v=8242 line 10 > Function:3:133\ne@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:5200\ns.template@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:5260\ngenerateLegend@http://maharatest/js/chartjs/Chart.min.js?v=8242:10:11904\nfetch_graph_data/<@http://maharatest/js/mahara.js?v=8242:922:38\nsendjsonrequest/<@http://maharatest/js/mahara.js?v=8242:362:17\ni@http://maharatest/js/jquery/jquery.js?v=8242:2:27060\nadd@http://maharatest/js/jquery/jquery.js?v=8242:2:27364\nsendjsonrequest@http://maharatest/js/mahara.js?v=8242:345:5\nfetch_graph_data@http://maharatest/js/mahara.js?v=8242:903:5\n@http://maharatest/admin/users/statistics.php:455:13\ni@http://maharatest/js/jquery/jquery.js?v=8242:2:27060\nfireWith@http://maharatest/js/jquery/jquery.js?v=8242:2:27828\nready@http://maharatest/js/jquery/jquery.js?v=8242:2:29619\nJ@http://maharatest/js/jquery/jquery.js?v=8242:2:29804\n"; To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1778451/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
