Reviewed: https://reviews.mahara.org/9129 Committed: https://git.mahara.org/mahara/mahara/commit/e129f68764414a151e013099a36ea867558c2071 Submitter: Robert Lyon ([email protected]) Branch: master
commit e129f68764414a151e013099a36ea867558c2071 Author: Matt Clarkson <[email protected]> Date: Thu Sep 13 10:29:18 2018 +1200 Bug 1792246: generic open in new window JS behatnotneeded - current tests will verify this change Change-Id: I2e9a0e945aacfbc7f45ee219d90076553ca530a4 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1792246 Title: make a more generic js workround for target _blank Status in Mahara: Fix Committed Bug description: In bug https://bugs.launchpad.net/mahara/+bug/1558361 we removed the use of target _blank because of XSS issues. There is a js workaround to the problem now and so we can allow the 'target="_blank" again and then override it via jQuery. Actually it would be safer to do something like 'data-target="_blank"' that way if a jQuery error is created on the page the link would not fall back to old behaviour To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1792246/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
