Reviewed: https://reviews.mahara.org/9179 Committed: https://git.mahara.org/mahara/mahara/commit/85f84f0432307d2ed78271ffd6184857f87ef62a Submitter: Robert Lyon ([email protected]) Branch: 18.10_STABLE
commit 85f84f0432307d2ed78271ffd6184857f87ef62a Author: Cecilia Vela Gurovic <[email protected]> Date: Thu Oct 4 12:08:33 2018 +1300 Bug 1795096:confirmation dialogue when deleting IdP behatnotneeded Change-Id: Ice8e039ed2163e42f062c42ea90c335659cc6926 (cherry picked from commit 9e2543659729fba25a2f185ac9c078ddd582eb20) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1795096 Title: Turn delete button into button and add confirmation dialogue when deleting IdP Status in Mahara: Fix Committed Bug description: In bug #1716820 we introduced that the metadata of an IdP can be deleted when not used anymore. That's been added to /admin/extensions/pluginconfig.php?plugintype=auth&pluginname=saml The confirmation dialogue is missing and the deletion is immediate. Since we only have a "Save" button but no "Cancel", it can't be undone. Since it is a distructive method, a confirmation pop-up would be useful as we have for other delete actions. The icon should also sit on a button. It doesn't need a heading as we normally do not have headings for icons. If the heading is kept, the button needs to move into the middle of the column to sit correctly under the heading. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1795096/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
