Reviewed: https://reviews.mahara.org/9250 Committed: https://git.mahara.org/mahara/mahara/commit/de470bec99813807fafefe389f97d6c9e0744e6b Submitter: Robert Lyon ([email protected]) Branch: 18.10_STABLE
commit de470bec99813807fafefe389f97d6c9e0744e6b Author: Cecilia Vela Gurovic <[email protected]> Date: Thu Oct 18 10:43:09 2018 +1300 Bug 1797276: escape admin reserved word in Mysql8 reserved keyword found needing to be fixed: admin was set to reserved in mysql 8.0.2 and then changed back to unreserved in 8.0.12 we need this patch for the version in between them behatnotneeded Change-Id: Ife693b3d490ca5fd1112d0a55ff1ae74a9579aa5 (cherry picked from commit 06e3f6b88871668c4f1e79e26d19f2ed69bfe9fa) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1797276 Title: New reserved keywords in mysql8 cause SQL errors Status in Mahara: Fix Committed Bug description: I'm running PHP7.2 on Ubuntu 16.04 with MYSQL8 in Firefox. There's an SQL error for the groups report that occurs when running mysql. If you go to http://mahara/admin/users/statistics.php while running postgres, you see the reports page as expected. In mysql you get an error (Reports page in mysql.png - attached): [WAR] a6 (lib/dml.php:517) Failed to get a recordset: mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups FROM "group" WHERE deleted = 0 GROUP ' at line 1] in EXECUTE(" SELECT grouptype, COUNT(id) AS groups FROM "group" WHERE deleted = 0 GROUP BY grouptype ORDER BY groups DESC")Command was: SELECT grouptype, COUNT(id) AS groups FROM "group" WHERE deleted = 0 GROUP BY grouptype ORDER BY groups DESC To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1797276/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
