Really not sure which is the best solution.
1.) Force LDAP not to have spaces - which would break current installs.
2.) Add a special character in the username feature (Like Moodle) which 
existing users of Mahara will need to know before updating.
3.) leave (not really broken - more of a data checking/ entry issue?)

LDAP usernames can contain spaces.
Putting in a trim feature would then break all existing users on Mahara where 
their LDAP has been set up to allow spaces. So - allowing spaces in LDAP 
username looks to be allowed for this very reason.

Moodle put in this solution:
$CFG->extendedusernamechars = true
To allow special characters in usernames (Which old LDAPS out there use).

As Mahara allows special characters once you choose LDAP - it already
resolves a Moodle issue.

You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or forum before editing or unsubscribing it!

  New username isn't checked for spaces when added to LDAP

Status in Mahara:

Bug description:
  Mahara version: 16.10.3

  When adding a new user, if you select an institution/authentication
  method with LDAP, the usersame is not being checked for
  leading/trailing spaces, and it isn't trimmed before being added to
  the database. Users can be created with usernames like " newuser ".

  If you try to do this with a non LDAP authentication method, it thows
  an error and will not continue (although the error message does not
  highlight the username field as the source of the error in this case).

  I've fixed it locally with trim() around the username value before
  it's put into the databse.

To manage notifications about this bug go to:

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to