Reviewed: https://reviews.mahara.org/9713 Committed: https://git.mahara.org/mahara/mahara/commit/74bfb4a6197bfd0b8abc83c58c63d49ce4dcaadb Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 74bfb4a6197bfd0b8abc83c58c63d49ce4dcaadb Author: Evonne Cheung <evo...@catalyst.net.nz> Date: Fri Apr 5 15:29:57 2019 +1300 Bug #1822911 User icons not appearing circular in some themes Use object-fit:cover to force non-square images to size to the min width/height of the image loaded so that it displays the center of the image in the correct ratio, hence fixing the issue of oval shapes. Added extra classes to tell theme what size the images are to display, ie .user-icon-20, .user-icon-40, .user-icon-60, etc, and .user-icon-inline for when username is displayed inline with user icon. behatnotneeded Change-Id: I28e0b37d0961c3be0195f4baef704262a0547af0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
