Reviewed: https://reviews.mahara.org/9753 Committed: https://git.mahara.org/mahara/mahara/commit/5d0989ada692ce1185418aab6668c01ad092668e Submitter: Robert Lyon ([email protected]) Branch: master
commit 5d0989ada692ce1185418aab6668c01ad092668e Author: Evonne Cheung <[email protected]> Date: Fri Apr 12 10:50:44 2019 +1200 Bug #1824044 'skip to main content' link skips the new page header on collections Put the pageactions.tpl inside pageheader.tpl so the ordering of elements is better for screenreaders. Skip to main content now goes either to #main or #header-content if dealing with a custom page header. The collection navigation custom-dropdown is now focusable, with clicking func and tab to and press enter for accessibility. Style guide updated accordingly. behatnotneeded Change-Id: I54c17a69c3f55aa4f896ea02be01e04220d4dd4c -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1824044 Title: 'skip to main content' link skips the new page header on collections Status in Mahara: Fix Committed Bug description: When tabbing through a page with a screenreader, there is a 'skip to main content' link in the header that allows users to skip having to tab through all of the menu items before getting to the content of a page. Since the new collection page header has been added, using this link completely misses the header elements. To replicate: 1. Navigate to create -> Pages and collections 2. Create a page 3. Create a collection 3.1. Add the page from step 2 to the collection 4. View the collection 5. Use the tab key to navigate through the page 6. When 'skip to main content' link appears, click enter Expected result: Start tabbing through the header section Actual result: Start tabbing through the comments block (Or another block if one was added in step 2) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1824044/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
