Reviewed: https://reviews.mahara.org/10080 Committed: https://git.mahara.org/mahara/mahara/commit/c40945d82fb907ebea53264c0863d3e97c120b87 Submitter: Robert Lyon ([email protected]) Branch: 19.04_STABLE
commit c40945d82fb907ebea53264c0863d3e97c120b87 Author: Ghada El-Zoghbi <[email protected]> Date: Fri Jun 14 14:10:05 2019 +1000 Bug 1832796: Group journals - display add link only if user has permission For a regular member who does not have permission to add a journal to a group, the display message should not include the 'Add one' link. Sponsored by The Australian National University behatnotneeded Change-Id: I657f47b51b2c505cab4c2501f39e03b0252bdf72 (cherry picked from commit 9188fc20704de7ff238da2963276f7b84c9aa6fd) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1832796 Title: Adding Journal - message displayed to user is misleading Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgres Browser: FF and Chrome The message displayed to a group member who is not allowed to enter a journal is misleading. They are given a link to 'Add one' but when they click on it, it displays they don't have permission to do so. To reproduce: * Create an institution: Inst1 * Add users to Inst1 - user1, admin1 * Create a group for Inst1: Associated with institution: Inst1 Open = No Controlled = Yes Request = No Friend Invitations = Yes Create and edit: everyone except ordinary members Publicly viewable group = No Hide group = Yes Hide membership = Hide members Hide membership from members = No Auto-add users = No Shared page notifications = All group members Comment notifications = All group members * Add user1 with role = member to the group * Add admin1 with role admin * Log in as user1 and go to group > Journals * Display message says: There are no journals in this group. Add one. * Click on 'Add one' link * User is presented with message they don't have permission. * Expected: They should not be presented with the link to click 'Add one'. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1832796/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
