Patchset: https://reviews.mahara.org/#/c/10304/6 Browser tested: Firefox Theme used: Raw
TEST SCENARIO: Verify that exported HTML portfolio/pages with image blocks that have Comments and/or Details can be viewed as expected. -------------- *PRECONDITIONS: --------------- 1) Logged in (non administrative) user1 has a newly created HTML export of a portfolio/page with at least two image blocks (one commented upon - public and private ones - and one not) and one folder block (that contains the image/s used in the image blocks). 2) The portfolio/page is shared with at least one other non administrative user (user2) who has also commented (some private and some public) on the block with prior comments. 3) The portfolio/page is exported as HTML with comments option selected, and the downloaded file unzipped and the index.html file is opened in the browser **TEST STEPS: ------------- Verify that the portfolio/page content displays as expected with special focus on the block comments and details. Step 1. Open the index.html file to view the exported material. Step 2. Click on the image block's image to view the details and comments. **Image block HTML export bug: the image block details and comments are not accessible via the image block but they are via the folder block file - please see the attachments (with prefix SS1 shows the console error when the user attempts to click the image in the image block, with prefix SS2 shows the details and comments displayed when user clicks the folder block's image filename). ** Attachment added: "SS1 Exported HTML - image details and comments not accessible.png" https://bugs.launchpad.net/mahara/+bug/1827811/+attachment/5288417/+files/SS1%20Exported%20HTML%20-%20image%20details%20and%20comments%20not%20accessible.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827811 Title: Move "Add comment" and "Details" into modal with "Comments" Status in Mahara: In Progress Bug description: This is part of the page revamp: https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision Currently, the "Add comment" and "Details" links at blocks that can have them, takes you to a separate page where you can view the artefact's metadata and can leave comments. When you view comments, they are already displayed in the modal directly on the page, but you can't leave a comment yet. The things to be done: - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link. - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up. This would also mean to review all the "Details" on blocks as some of them are not needed. For example, clicking the details link next to a plan task only shows that single plan task again without any additional details. The "Details" should only be there when there is additional metadata information but not simply repeating the block content. The title of the modal (the one in the green bar) would be the blocktype as the title of the block is listed below. A decision still needs to be made on whether comments can be paginated in the modal or if they are shown all one after another (which might get quite long). We are not changing anything else from the proposal as that requires Gridstack to be implemented first. This is a standalone usability improvement independent of Gridstack. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
