Reviewed: https://reviews.mahara.org/10384 Committed: https://git.mahara.org/mahara/mahara/commit/ca2b5406848c44ab0cd8742f9f68a4cc235d68d6 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit ca2b5406848c44ab0cd8742f9f68a4cc235d68d6 Author: Robert Lyon <[email protected]> Date: Sun Sep 29 09:34:30 2019 +1300 Bug 1827445: Need to revert to old way during upgrade Otherwise there is brokenness in upgrade behatnotneeded Change-Id: I1523ec044a9caecd52f5baa2a86308460ba6c284 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827445 Title: Improve efficiency when checking if a table field exists Status in Mahara: Fix Committed Bug description: When upgrading we use a field_exists() check to see if a table has a certain column or not which is fine there as upgrade chunks are a one- time execution run when users are all logged out. However we have begun to use field_exists() within other parts of the code and so this can get called on every page load by multiple users at once. This requires fetching the ddl.lib file and setting ul an XMLDB table object and an XMLDB field object which has overhead. Instead we should just query the database directly and ask it if the table has the column or not So instead of doing: require_once('ddl.php'); $table = new XMLDBTable('tablename'); $field = new XMLDBField('fieldname'); if (field_exists($table, $field)) { ... } We could just do: if (column_exists('tablename', 'fieldname')) { ... } And have the column_exists function that call the database directly To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
