Reviewed: https://reviews.mahara.org/9509 Committed: https://git.mahara.org/mahara/mahara/commit/2c861ec11807d1747d631a9ed568b985bb17bf17 Submitter: Robert Lyon ([email protected]) Branch: master
commit 2c861ec11807d1747d631a9ed568b985bb17bf17 Author: Cecilia Vela Gurovic <[email protected]> Date: Thu Jan 31 10:11:11 2019 +1300 Bug 1813987: Creating a new page with gristack layout add a new block, place it anywhere in the grid, edit configuration and delete it. It will save it in the db on table block_instance_dimension but not display it in view or edit mode yet Also included a small fix in xmldb postgres class generator to handle reserved words in getAlterFieldSQL function Failing tests: - most of them are failing when adding a new block to the page because they expect to have a modal to choose the position where to place block. That modal was removed for this patch but there will be a similar one in patch: https://reviews.mahara.org/#/c/9952 and those tests will be fixed there - a few tests failed when they couldn't find text inside the blocks because they are not expanded to fit the content yet. This is added in patch: https://reviews.mahara.org/#/c/9986 and they will be fixed there behatnotneeded Change-Id: If4521a6315f6e8cc5d88693f536946dace359288 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1813987 Title: more usable and simpler layout selector for Mahara pages Status in Mahara: Fix Committed Bug description: We are planning to improve the layout of mahara pages using the gridstack library. http://gridstackjs.com/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1813987/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
