Reviewed: https://reviews.mahara.org/10410 Committed: https://git.mahara.org/mahara/mahara/commit/0e0ef413b61c451916dc0dc4508c7ed5cd18babc Submitter: Robert Lyon ([email protected]) Branch: master
commit 0e0ef413b61c451916dc0dc4508c7ed5cd18babc Author: Robert Lyon <[email protected]> Date: Sun Oct 6 19:54:33 2019 +1300 Bug 1835869: Remove obsolete skin options The old options to be removed are: - header_text_font_color - header_link_normal_color - header_link_normal_underline - header_link_hover_color - header_link_hover_underline - header_logo_image - view_background_color - view_background_image - view_background_repeat - view_background_attachment - view_background_position - view_background_width - view_table_border_color - view_table_header_color - view_table_header_text_color - view_table_odd_row_color - view_table_even_row_color - view_button_normal_color - view_button_hover_color - view_button_text_color behatnotneeded Change-Id: I909e7bcb4f559d9cd052cf4c7b2b80982ecf109c Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1835869 Title: Skins to support new page header Status in Mahara: Fix Committed Bug description: Mahara: 19.04.0 OS: Linux 16.04 DB: Postgers Browser: FF / Chrome The skin is not respecting the new pageheader of a page. To reproduce - Repeat only horizontally: 1. Create a new skin (Skin1): - Add a Background image (attached) - Background image report = Repeat only horizontally - Background image attachment = Fixed - Background image position = Top - Save 2. Create a new page that uses this new skin (Skin1) - Page title = Skin Test - Current skin = Skin1 - Save - Add any block to the page (i.e. text) 3. Display the page Results: The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image displayed in the right/left margins. Expected Result: The page header (i.e. page banner at top) should display the background image in the left/right margin as the rest of the page. ===== To reproduce - Repeat Vertically: 1. Updated Skin1: - Background image report = Repeat Vertically - Save 2. Display (refresh) Skin Test page Results: The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image displayed in the right/left margins. At the bottom of the page, the image's bottom is seen in the center of the page. Expected Result: The page header (i.e. page banner at top) should display the background image in the left/right margin as the rest of the page. At the bottom of the page, the image's bottom is seen in the center of the page. ===== To reproduce - Repeat both directions: 1. Updated Skin1: - Background image report = Repeat both directions - Save 2. Display (refresh) Skin Test page Results: The page header (i.e. page banner at top) is displayed across the entire page (from right to left) whereas the rest of the page below the banner has the background image repeated in the right/left margins and at the bottom of the page. Expected Result: The page header (i.e. page banner at top) should display the repeated background image in the left/right margin as the rest of the page and at the bottom of the page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1835869/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
