Patch for "master" branch: https://reviews.mahara.org/10461
-- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1846972 Title: Skin text colour defaults should default to the theme colours Status in Mahara: In Progress Bug description: When you set up a skin, the font colours have a "Default" option. That is not the theme default colour though but the default colour seen on the page when getting to the skin's page for the first time. Now that we are having header background images and we expect people to only want to change that background rather than build a full skin, it would be better if the "Default" option was the theme default colours for these options so that the only thing that changes is the header background image. So instead of having "Default" as option, we'll have "Theme default" and no value saved for the skin as it will inherit the colour from the theme. This should be done for all colours on the "Text" tab. To replicate: 1. Create a skin. 2. Change the background image. 3. Tick the "Default" options for the font colour options. 4. Add a "Text" block with a link to a page that has the skin. Expected result: The link is displayed in the theme's regular link colour. Actual result: The link is displayed in blue, i.e. the skin's default colour. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1846972/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
