Reviewed: https://reviews.mahara.org/10486 Committed: https://git.mahara.org/mahara/mahara/commit/7f475cbeb9e8ae6ff8d4e097e9c20c741a38f12d Submitter: Robert Lyon ([email protected]) Branch: 19.10_STABLE
commit 7f475cbeb9e8ae6ff8d4e097e9c20c741a38f12d Author: Robert Lyon <[email protected]> Date: Fri Oct 25 12:40:19 2019 +1300 Bug 1838915: Icon missing on Site options -> account settings The icon-user-cog is not a 'regular' styled icon Can only see the problem in older browsers / systems behatnotneedeed Change-Id: I02087276f626ce0b095dae7409dc878f035a6b35 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 87577fde65f15d59556ba86759878d1e7f284baf) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1838915 Title: Comment ratings not displaying correctly with font-awesome5 Status in Mahara: Fix Committed Bug description: The hollow (not rated) icons are not showing This will need to be tested for all the icon choices - star, heart, thumbsup, tick, smile (a new one) To test admin part: 1) Go to Admin -> Extensions -> Plugin administration and click on the cog for 'Comments' 2) Turn on 'Enable comment ratings' 3) Select a new icon type 4) Save On this page you should see some icons filled in and some hollow in the generated example line To test comments part on page: 1) Go to a page and add a comment and choose a rating by clicking on the icon 2) Make sure the comment has the rating icons showing To test comments part on artefact: 1) Go to a page and add an artefact, like an image, then view the page and click on details link 2) Make a comment on the artefact and choose a rating by clicking on the icon 3) Make sure the comment has the rating icons showing To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1838915/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
