Reviewed: https://reviews.mahara.org/10489 Committed: https://git.mahara.org/mahara/mahara/commit/7bcb5dd3ab924b49aafe0f8028c1d4871776cacf Submitter: Robert Lyon ([email protected]) Branch: 18.10_STABLE
commit 7bcb5dd3ab924b49aafe0f8028c1d4871776cacf Author: Robert Lyon <[email protected]> Date: Mon Oct 14 08:43:36 2019 +1300 Bug 1847750: Adding space in constructed sql query To avoid sqashing 'AND' statement against previous bit behatnotneeded Change-Id: Ifac0c97c0c7d37e624c2fda574758b62132fc297 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 8857c1f6f14b69f4cf60f3a89caf24d71b649d59) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1847750 Title: SQL statement missing space Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Hello, There is a problem with the SQL syntax within htdocs/search/internal/lib.php (branch 18.10_STABLE > line 854). If $ltiwhere assigns on false, the query concatenates at line 862, but is missing a space after the 0. To replicate: - ensure the plugin module_lti is not installed - navigate to /group/find.php (Can be accessed from the home page > Engage) Looks like this bug was introduced here: https://github.com/MaharaProject/mahara/commit/b078b3a848 Thanks, Matt To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1847750/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
