Reviewed: https://reviews.mahara.org/10542 Committed: https://git.mahara.org/mahara/mahara/commit/ce64fb86f406bc0d6ab4aa398320593642df1c11 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: 19.10_STABLE
commit ce64fb86f406bc0d6ab4aa398320593642df1c11 Author: Robert Lyon <[email protected]> Date: Thu Oct 31 08:58:13 2019 +1300 Bug 1850631: Extending the check for MariaDB / Percona To look at 'version' value if the 'version_comment' value doesn't return a match behatnotneeded Change-Id: I71a45c8327a3d65cc32620ccfb3ee2488b06db03 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 198a5ad857b324e0c91ff810d6df9d4979a9c9e8) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1850631 Title: Bug 1752688 is back in Debian 10 Status in Mahara: Fix Committed Bug description: In upgrading Mahara 17.04.1 to 19.10rc1 OR to 18.04.0 the upgrade fails with "[DBG] 69 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'JSON ), '$.id')" this is because the wrong variable is being used to check whether DB is Maria or Mysql in lib/dml.php 1569 $mysqltype = mysql_get_variable('version_comment'); since MariaDB [(none)]> show variables where Variable_name like 'version%'; +-------------------------+------------------------------------------+ | Variable_name | Value | +-------------------------+------------------------------------------+ | version | 10.3.17-MariaDB-0+deb10u1 | | version_comment | Debian 10 | | version_compile_machine | x86_64 | | version_compile_os | debian-linux-gnu | | version_malloc_library | system | | version_source_revision | 4b5a14d0fe3d6945a0a9516261f563dcfd1f2c9c | | version_ssl_library | YaSSL 2.4.4 | +-------------------------+------------------------------------------+ 7 rows in set (0.002 sec) My MariaDB version is 10.3.17-MariaDB-0+deb10u1 (a debian package) My Server OS is Debian 10 The original version of Mahara was on Debian 8.11 and DB server was Mysql 14.14 distrib 5.5.62 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1850631/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
