Reviewed: https://reviews.mahara.org/10546 Committed: https://git.mahara.org/mahara/mahara/commit/62cda412d0d72d92bd7786d401d51ac897a37029 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch: 19.10_STABLE
commit 62cda412d0d72d92bd7786d401d51ac897a37029 Author: Cecilia Vela Gurovic <cecili...@catalyst.net.nz> Date: Thu Oct 31 13:57:28 2019 +1300 Bug 1785985: remove prefix from db table before adding to ES queue behatnotneeded Change-Id: I1fa4b026234fb1cdc06786d864e6cc655870c85a (cherry picked from commit 9be8c499a0a373e8742ae5dbcea177a088596715) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785985 Title: Remove triggers from Mahara database Status in Mahara: Fix Committed Bug description: I've created a forum post to discuss this: * https://mahara.org/interaction/forum/topic.php?id=8324 Basically, my reasoning is: 1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain. 2. Mahara already has the concept of events in place. We can move the functionality of each trigger into an event. We would then have more control over the event. For example, don't action an event during an upgrade. 3. Triggers make it difficult to see what is actually happening. They are not transparent. If you weren't aware that there is a trigger on the table, it can make it difficult to track down why something is behaving in a certain way. We can start slowly by removing one at a time. It doesn't have to happen all at once. Just my thoughts. Cheers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
