Reviewed: https://reviews.mahara.org/10565 Committed: https://git.mahara.org/mahara/mahara/commit/3487188098b93f85493b92a58e55b8d6a03b6a22 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: 19.10_STABLE
commit 3487188098b93f85493b92a58e55b8d6a03b6a22 Author: Robert Lyon <[email protected]> Date: Mon Nov 4 12:44:20 2019 +1300 Bug 1851176: Adding a skin when on custom theme and using dbprefix Get table not found error Also fix for Bug 1851175 - as both fixes were to escape table name correctly Note: also fixed another table call that was not escaped correctly behatnotneeded Change-Id: I1acdafe9c29aa610a8d947b6fbbf95883b26f8c6 Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit 6459c465101d6242f47a5e65c53fb7e3f18ddd19) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1851176 Title: Unformatted table name breaks skin editing Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: When you are in an institution with configurable theme (custom) set and the site database is using $cfg->dbprefix You get the following error Failed to get a recordset: postgres8 error: [-18: ERROR: relation "style_property" does not exist LINE 1: SELECT sp.value FROM style_property sp JOIN institution i ON... ^] in EXECUTE("SELECT sp.value FROM style_property sp JOIN institution i ON i.style = sp.style AND sp.field = ? WHERE i.name IN ('instone') ORDER BY i.name LIMIT 1")Command was: SELECT sp.value FROM style_property sp JOIN institution i ON i.style = sp.style AND sp.field = ? WHERE i.name IN ('instone') ORDER BY i.name LIMIT 1 and values was (0:headings) to test: 1) Have clean database 2) in config.php set $cfg->dbprefix = 'cats'; 3) install site 4) add an institution and set it's theme to 'Configurable theme' and make sure 'Page skins' is set to Yes 5) add a user to this institution 6) login as user and add a skin To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1851176/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
