Reviewed: https://reviews.mahara.org/10609 Committed: https://git.mahara.org/mahara/mahara/commit/527fefd9cc373e75865b5e23bbe67c97d704f9a3 Submitter: Robert Lyon ([email protected]) Branch: master
commit 527fefd9cc373e75865b5e23bbe67c97d704f9a3 Author: Cecilia Vela Gurovic <[email protected]> Date: Thu Nov 14 16:04:20 2019 +1300 Bug 1852522: don't show 'Display page' for site templates behatnotneeded Change-Id: Id06668950d8b301d077142fd1c3200bd8ca46223 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1852522 Title: 'Display page' button should not be displayed for site templates Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: An error message is displayed when a site admin user tries to display a site template (Profile page, Dashboard page and group homepage templates) Error message: [WAR] 9f (lib/web.php:3490) redirect() should be called with either /[something] for local redirects or http[something] for absolute redirects Call stack (most recent first): redirect("") at /home/ceciliavg/maharacode/mahara/htdocs/view/view.php:126 To reproduce: -go to Configure site -> Pages & Collections -click on any of these 3 site templates: Profile page, Dashboard page or group homepage templates the page is displayed in view mode - Click on the 'Display page' button from the top right floating menu Expected result: The templates are not supposed to be shown in display mode. The 'Display page' button should not even be present for these pages Actual result: The 'Display page' button is displayed and clicking on it redirects to a page with an error message To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1852522/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
