Reviewed: https://reviews.mahara.org/10673 Committed: https://git.mahara.org/mahara/mahara/commit/d4ce24bdf678f3581618b6dcd81258275065eeb5 Submitter: Robert Lyon ([email protected]) Branch: 18.10_STABLE
commit d4ce24bdf678f3581618b6dcd81258275065eeb5 Author: Lisa Seeto <[email protected]> Date: Tue Dec 10 17:03:53 2019 +1300 Bug 1845133: "Delete" button visible on timeline for comments - added in versioning var to get_comment_options func and changed deleteform display logic in build_html func behatnotneeded Change-Id: Id9ed39ad8d1d8cf58f4351b5bca857442a6490bd Signed-off-by: Lisa Seeto <[email protected]> (cherry picked from commit 9a009bb1321ff3d8fffa1b224a84519b01d0bd3a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1845133 Title: "Delete" button visible on timeline for comments Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: When you are the owner of a page and have that page in a version on the timeline, you still see the "Delete" button for a comment. This should not be possible as it alters the history. The button doesn't do anything but only says "Processing". So it doesn't seem to work, but then we shouldn't display it at all. To replicate: 1. Create a page with a couple of blocks. 2. Make a couple of comments on the page. 3. Save the page to the timeline. 4. Enter your timeline. 5. Delete a comment. Expected result: There is no trash icon to indicate that you can delete a comment. Actual result: When pressing the delete button is just says "Processing". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1845133/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
