Reviewed: https://reviews.mahara.org/10696 Committed: https://git.mahara.org/mahara/mahara/commit/96a36e92d451de0bd50936cf433b648ed89172eb Submitter: Cecilia Vela Gurovic ([email protected]) Branch: 19.10_STABLE
commit 96a36e92d451de0bd50936cf433b648ed89172eb Author: Lisa Seeto <[email protected]> Date: Mon Nov 25 14:47:22 2019 +1300 Bug 1853387: jsform field defaults to no when field is disabled - alter the way checkbox disabled fields are processed if they have default values supplied - add get_element_option(name, option) to Pieform behatnotneeded Change-Id: I0b48cf148716acb70b865e3339a6b9fadfd762bb Signed-off-by: Lisa Seeto <[email protected]> (cherry picked from commit e99cb70275ce00ccb0c313ada4f3faacf50c31c7) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1853387 Title: jsform field defaults to no when field is disabled Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: An issue was picked up on Administration Menu->Configure site->Site options->Security Settings which could be a bigger issue with the way JSForms processes. Preconditions: In the config.php file have "recaptchaonregisterform" set to true, i.e $cfg->recaptchaonregisterform = true; Test: 1. Log in as site admin and go to Administration Menu->Configure site->Site options->Security Settings. 2. Scroll to "reCAPTCHA on user registration / contact us forms" and it should be set to "yes" as it reads from the config.php file. It should also be disabled. 3. Submit the page then view the Security Settings again. Expected result: The disabled "reCAPTCHA on user registration / contact us forms" button still shows "yes". Actual result: The disabled ""reCAPTCHA on user registration / contact us forms" button now shows "no" This issue was also seen in admin/site/networking.php during work on https://reviews.mahara.org/#/c/10616/2. Removing the jsform => true in the pieform stopped the disabled form fields defaulting to their 'false' values, i.e when the page is submitted. Mahara: 19.10_STABLE Browsers: Firefox and Chrome DB: Postgres To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1853387/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
