Reviewed: https://reviews.mahara.org/10662 Committed: https://git.mahara.org/mahara/mahara/commit/be433e76fe897b6f645150a424e4e62c4ae2ac81 Submitter: Robert Lyon ([email protected]) Branch: master
commit be433e76fe897b6f645150a424e4e62c4ae2ac81 Author: Lisa Seeto <[email protected]> Date: Tue Dec 10 11:39:02 2019 +1300 Bug 1848100: Skins - cannot Save changes once background image file previewed - passed down prefix in filebrower.tpl to pagemodal.tpl to create unique filebrowser modal id's, modified jq to target divs - optionally set page-modal id, adjust id's affected - include missing paginator script - alter data-dismiss to be conditional, added jq to close button event behatnotneeded Change-Id: If4d267ef65fce010fe9d8d242c56dd3bac331476 Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1848100 Title: Skins - cannot Save changes once background image file previewed Status in Mahara: Fix Committed Bug description: - Code: 19.10_STABLE - Browser tested: Chrome and Firefox - Theme: Primary school and Raw Preconditions: 1. A logged in person has at least one image in their home files folder and at least one sub-folder named 'images' with several image files in it. Test steps: (repeat these for each browser/theme) 1. Person selects to create a new skin (Main menu|Create|Skins--> Create skin - or edit an existing one ) 2. Select the 'Page' tab 3. Select the Page background image's 'Add a file' button and select the 'image' sub-folder 4. Select a filename to preview a file's content 5. Select the tick to select a file 6. Save the page ✘ Actual result: (see Chrome attachment) the selected change cannot be saved as the screen is disabled/greyed out. Work around: the user can reload the screen and then re-enter their changes (WITHOUT previewing a background image file!) then Save them. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1848100/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
