Reviewed: https://reviews.mahara.org/10695 Committed: https://git.mahara.org/mahara/mahara/commit/a94f1fa1899679e73dea315400365d8b2e1e2930 Submitter: Robert Lyon ([email protected]) Branch: master
commit a94f1fa1899679e73dea315400365d8b2e1e2930 Author: Cecilia Vela Gurovic <[email protected]> Date: Tue Dec 31 10:24:13 2019 +1300 Bug 1852026: refactor getUrlParameter(param, url) to use JS function URLSearchParams. The result should stay the same, it should not change any behaviour. The function is used in : ./htdocs/relatedtags.php ./htdocs/tags.php ./htdocs/js/adminusersearch.js ./htdocs/js/export.js ./htdocs/js/privacy.js ./htdocs/js/adminexportqueue.js ./htdocs/artefact/annotation/blocktype/annotation/js/annotation.js ./htdocs/artefact/plans/js/planview.js ./htdocs/artefact/peerassessment/blocktype/peerassessment/js/peerassessment.js ./htdocs/artefact/file/js/filebrowser.js ./htdocs/theme/raw/js/formtabs.js ./htdocs/view/choosetemplate.php the function updateUrlParameter is used in: ./htdocs/relatedtags.php ./htdocs/js/privacy.js ./htdocs/js/mahara.js ./htdocs/artefact/file/js/filebrowser.js behatnotneeded Change-Id: I1593f59624a5de3f90054a702d4e94dd7029f321 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1852026 Title: using URLSearchParams to get url parameters in js Status in Mahara: Fix Committed Bug description: we have a function in js/mahara.js called getUrlParameter(param, url) We should update that one to use this " new URLSearchParams() " seen as it's valid for every browser except old IE (which we don't support) https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams Actually we could also update our updateUrlParameter() as the URLSearchParams() can do get() and set() To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1852026/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
