Reviewed: https://reviews.mahara.org/10633 Committed: https://git.mahara.org/mahara/mahara/commit/467c1163bafcf115e1c45dcb57067d621b39a846 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit 467c1163bafcf115e1c45dcb57067d621b39a846 Author: Cecilia Vela Gurovic <[email protected]> Date: Tue Dec 3 17:54:09 2019 +1300 Bug 1800319: redirect to review persmissions when adding views to collection this will change the redirect page after editing the access rules from a view in a collection. Instead of taking you to the edit page of the view, it will redirect to pages and collections for a portfolio behatnotneeded Change-Id: I14ad1f02048b1952d4531da854880ddcb2f93ff7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1800319 Title: Revise merging of sharing permissions for a collection Status in Mahara: Fix Committed Bug description: When pages are added to a collection, all sharing permissions are merged and a notice provided on screen to the user so that they know it happened. However, the details are not mentioned. By merging sharing permissions, it can happen that one person or group is mentioned multiple times, e.g. when a page was shared without peer or manager permissions but then is added to a collection that contains these permissions. This can get confusing quickly as there are contradicting sharing permissions. Furthermore, in the case of the peer permission, it would give a peer access to portfolio content they shouldn't see. It would be beneficial if a user were able to review the sharing permissions after adding one or more pages to a collection so as not to overshare by accident. I see two scenarios: 1. Leave things as they are when the sharing permissions for the collection and the newly added page(s) are identical and mention that in the info box at the top of the page. 2. When the sharing permissions are not identical (for whatever reason), require the user to continue to the sharing permissions screen when clicking the "Done" button at the bottom of the page. It would not be enough to provide a link in an info box because they are easily overlooked. When the "Done" button is clicked, a modal should come up informing the user that they need to review the permissions as they have been merged. Potential text for the modal: The permissions of the newly added page(s) were merged into the existing collection permissions. Please review them carefully and make any necessary adjustments. Button text: Review (we don't need "Review permissions" as that is mentioned in the text and makes the button text very long; even more so in other languages) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1800319/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
