Reviewed: https://reviews.mahara.org/10782 Committed: https://git.mahara.org/mahara/mahara/commit/674725c74b9b78489097643163ac44c2d46ec340 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit 674725c74b9b78489097643163ac44c2d46ec340 Author: Lisa Seeto <[email protected]> Date: Thu Feb 27 15:14:09 2020 +1300 Bug 1864757: Can't comment on artefacts on public or secret URL pages - change js to target fields for both logged and logged out users - add public setting to files Change-Id: I8c869cbb0e82c84f692d69615ec839a5a2afba9e Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1864757 Title: Can't comment on artefacts on public or secret URL pages Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Bug description: When you shared a page publicly or via secret URL, i.e. you are not needing to log in to view the page, you can't comment on artefacts that should allow comments because the site asks "Reload the page to log in". It seems that currently, we have a restriction in place that content on the new modal that was introduced in Mahara 19.10 can only be accessed when the viewer is logged into the site. To replicate: 1. Create a page and add a journal entry and an image via the image block. Make sure that both allow comments. 2. Share the page publicly and via a secret URL. 3. Navigate to the page as a not-logged in person. Expected results: 1. When you click the image, the modal shows the details and the commenting possibility. 2. When you activate the "Details" mode, you can click the "Add comment" link for both journal entry and image and the modal shows the metadata that you can see when you are logged in and you can comment. Actual result: The modal opens but is empty. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1864757/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
