Reviewed: https://reviews.mahara.org/10960 Committed: https://git.mahara.org/mahara/mahara/commit/9bf6fc173ecbe1912a762b8dfb0ebeb0fec970a3 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: 20.04_STABLE
commit 9bf6fc173ecbe1912a762b8dfb0ebeb0fec970a3 Author: Cecilia Vela Gurovic <cecili...@catalyst.net.nz> Date: Wed Apr 29 19:01:21 2020 +1200 Bug 1875785: replace target attr in links: wait for the block to load Whether an external <a> link has target=_blank or not we should open them in external tab/window to differentiate mahara site from external content check https://bugs.launchpad.net/mahara/+bug/1802205 behatnotneeded Change-Id: I371a9f63132ae49eedd7543b682fe80602130117 (cherry picked from commit 9f6a3896d150d03f7c541f7b7860fb1bf3373f49) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1875785 Title: External links in Mahara no longer open in external tab/window by default Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Code: Release 2020.04_RC2 Browser/s: Chrome & Firefox Theme: Raw Summary: The functionality for related bug #1802205 'Make all external links in Mahara open in external tab/window by default' no longer works. Steps: As logged in PersonA: 1. Create a new page with a text block on it that has a few/5 paragraphs of text. 2. Use the tinymce editor to add the following links before the text paragraphs using the Insert/Edit Link modal: a. External URL = https://www.catalyst.net.nz/ Text to display = 'Catalyst default-None, new tab/window' Open link in... = 'None' b. External URL = https://www.catalyst.net.nz/ Text to display = 'Catalyst -same page' Open link in... = 'Same page' c. External URL display = https://www.catalyst.net.nz/ Text to display = 'Catalyst -new tab/window' Open link in... = 'New window' d. Internal URL = http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php Text to display = 'Profile page default-None, same tab/window' Open link in... = 'None' e. Internal URL = http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php Text to display = 'Profile page - same page', Open link in... = 'Same page' f. Internal URL = http://http://mahara.rdaymond.wgtn.cat-it.co.nz/artefact/internal/index.php Text to display = 'Profile page - new tab/window' Open link in... = 'New window'. 3. At the bottom of the page, enter the text 'End of page' select the text and use the tinymce editor to create an anchor tag (3rd option line, second to last icon) named 'Page_End'. 4. Create the following in block link to the 'Page_End' anchor from the top of the page: URL = #Page_End Text to display = 'Link to page end -default None' Open link in... = 'None' Expected results: When selected, each link should behave as per its displayed link text. Actual results: all links behave as expected EXCEPT for 2.a. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1875785/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
