Reviewed: https://reviews.mahara.org/10954 Committed: https://git.mahara.org/mahara/mahara/commit/9cecf19dcef8e7146a0ca997a015d6016eb44a06 Submitter: Robert Lyon ([email protected]) Branch: master
commit 9cecf19dcef8e7146a0ca997a015d6016eb44a06 Author: Lisa Seeto <[email protected]> Date: Mon May 4 10:52:45 2020 +1200 Bug 1867822: Tidy up the artefact attachments_from_id_list() function - alter files to use attachments_from_id_list() - alter attachments_from_id_list func params Change-Id: I32b26586deb2f2a1b6a624f2c7afc4520a1a57ff Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1867822 Title: Tidy up the artefact attachments_from_id_list() function Status in Mahara: Fix Committed Bug description: There are a bunch of places that call this function and then straight after do a loop to add a file icon We should do the adding of the file icon within the call to attachments_from_id_list() eg: htdocs/artefact/resume/lib.php:2088 htdocs/artefact/blog/lib.php:1051 htdocs/artefact/comment/lib.php:511 htdocs/artefact/internal/notes.php:167 htdocs/artefact/internal/notes.json.php:167 Also there are a bunch of places where we don't even call the function and just duplicate it: htdocs/artefact/resume/composite.json.php: htdocs/artefact/resume/lib.php htdocs/artefact/blog/blocktype/recentposts/lib.php: These should be fixed to use the function we already have To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1867822/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
