Reviewed: https://reviews.mahara.org/11000 Committed: https://git.mahara.org/mahara/mahara/commit/51db06882401f084bab430ea24a27c629077655f Submitter: Robert Lyon ([email protected]) Branch: 20.04_STABLE
commit 51db06882401f084bab430ea24a27c629077655f Author: Cecilia Vela Gurovic <[email protected]> Date: Fri May 29 10:55:00 2020 +1200 Bug 1880803: copying a page after editing column widths manually there's a different fix for 19.04 because we change some of the code when implementing the gridstack layout behatnotneeded Change-Id: Ie809449c41b01ab7fc1adc3a8b7fd1118f30a896 (cherry picked from commit bbeadbd29388385d9100abbb050ff5ac5bfcc671) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1880803 Title: errors when copying a page after editing column widths manually Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: For any version newer than 19.04, follow the steps below and then upgrade. It will display the same errors when trying to copy or translate the view with the old layout. On 19.04 to replicate: - go to User menu-> Preferences -> Settigns - set 'Show controls to add and remove columns when editing a page' to yes and save - create a view - set a custom layout e.g. 3 rows with 3 columns and 1 row with 1 column - play with the column changing the widths - display the page and make a copy and try to edit the view the following errors are displayed [WAR] 28 (lib/view.php:2994) Undefined offset: 4 Call stack (most recent first): log_message("Undefined offset: 4", 8, true, true, "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520 error(8, "Undefined offset: 4", "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994, array(size 4)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994 View->removerow(array(size 2)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701 set_view_layout(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643 settings_submit(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544 Pieform->__construct(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166 Pieform::process(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445 pieform(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222 create_settings_pieform() at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106 [WAR] 28 (lib/view.php:2994) Undefined offset: 3 Call stack (most recent first): log_message("Undefined offset: 3", 8, true, true, "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520 error(8, "Undefined offset: 3", "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994, array(size 4)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994 View->removerow(array(size 2)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701 set_view_layout(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643 settings_submit(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544 Pieform->__construct(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166 Pieform::process(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445 pieform(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222 create_settings_pieform() at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106 [WAR] 28 (lib/view.php:2994) Undefined offset: 2 Call stack (most recent first): log_message("Undefined offset: 2", 8, true, true, "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:520 error(8, "Undefined offset: 2", "/home/ceciliavg/maharacode/mahara/htdocs/lib/view....", 2994, array(size 4)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/view.php:2994 View->removerow(array(size 2)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:701 set_view_layout(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:643 settings_submit(object(Pieform), array(size 16)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:544 Pieform->__construct(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:166 Pieform::process(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5445 pieform(array(size 5)) at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:222 create_settings_pieform() at /home/ceciliavg/maharacode/mahara/htdocs/view/editlayout.php:106 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1880803/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
