I verified this fix by setting up two institutions with the same metadata then slightly changing the metadata in one of the institution's settings in order to trigger another configuration save, saved the SAML configuration and then saved the institution, producing the error. I then applied the patch, repeated the steps and was able to successfully save the institution without any error messages or warnings
-- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892256 Title: Undefined variable: duplicates error when updating SAML metadata in SAML instance Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Confirmed Status in Mahara 20.04 series: Confirmed Status in Mahara 20.10 series: In Progress Bug description: This is because we can't chain the db query result and finding the resultant object value in the same "if" statement We need to break this down into testable parts To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
