Reviewed: https://reviews.mahara.org/11173 Committed: https://git.mahara.org/mahara/mahara/commit/48e2a2676186a532367db3eb36064f9ae8393364 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit 48e2a2676186a532367db3eb36064f9ae8393364 Author: Lisa Seeto <[email protected]> Date: Mon Aug 24 15:24:22 2020 +1200 Bug 1892664: Share access with users outside of institution is producing a warning - add in check for peoplein, set to array if false Change-Id: Ie8a4c98190b1a15c4a6f7556fd714e50c20d62eb Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1892664 Title: Share access with account holders outside of institution is producing a warning Status in Mahara: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: A warning is produced when a user who is the only member of an institution tries to share view access with a user outside of their institution. To reproduce: Have an institution with one member, and members outside of institution on a site 1. log in as institution member, create a page 2. Share the page with a person on the site who isn't in an institution (anyone from "Other people") and save Expected results: The page is updated with new access rules Actual results: A warning is being produced (see attached screen shot for more): [WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be array, boolean given Call stack (most recent first): log_message("array_keys() expects parameter 1 to be array, bool...", 8, true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at /home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521 error(2, "array_keys() expects parameter 1 to be array, bool...", "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at Unknown:0 array_keys(false) at /home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70 [WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be array, null given Call stack (most recent first): log_message("in_array() expects parameter 2 to be array, null g...", 8, true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at /home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521 error(2, "in_array() expects parameter 2 to be array, null g...", "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at Unknown:0 in_array("20", null) at /home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
