I have done some more investigation and confirmed this as a regression:
In 20.04_STABLE the modal opens with the images and download links (see
screenshot).
Inspecting the html shows no difference, but the request repsonse from
opening the modal shows the following console error in 20.10:
1 request
277 B / 789 B transferred
Finish: 38 ms
error true
error_number 400
error_name "ParameterException"
error_class "ParameterException"
error_message "The 'artefactid' parameter is not an integer"
error_rendered "A required parameter is missing or malformed\n\nThe
'artefactid' parameter is not an integer"
compared with a working response below:
1 request
8.74 KB / 9.30 KB transferred
Finish: 77 ms
error false
message Object { title: "Placeholder", html: "\n\n\n\n<div id=\"commentfiles\"
class=\"folder-card\">\n \n <h4 class=\"sr-only\">\n Folder contents:\n
</h4>\n\n <div class=\"fullwidth file-download-list\">\n <ul
class=\"list-group\">\n \n <li class=\"filedownload-item list-group-item\">\n
<a class=\"modal_link\"
title=\"405078_tumannost_krasnaya_xabbl_teleskop_1680x1050_(www.GdeFon.ru).jpg\"
data-toggle=\"modal-docked\" data-target=\"#configureblock\" href=\"#\"
data-blockid=\"83\" data-ar…itle=\"Download image
[www.imagesplitter.net](1).jpeg [19.2K]\"></span>\n <span
class=\"sr-only\">Download image [www.imagesplitter.net](1).jpeg
[19.2K]</span>\n </a>\n \n </li>\n \n </ul>\n </div>\n \n
\n</div>\n\n<script>\n jQuery('#configureblock .modal_link').off('click');\n
jQuery('#configureblock .modal_link').on('click', function(e) {\n
open_modal(e);\n toggleDetailsBtn();\n });\n</script>\n", message: "" }
message ""
title "Placeholder"
html "\n\n\n\n<div id=\"commentfiles\" class=\"folder-card\">\n \n <h4
class=\"sr-only\">\n Folder contents:\n </h4>\n\n <div class=\"fullwidth
file-download-list\">\n <ul class=\"list-group\">\n \n <li
class=\"filedownload-item list-group-item\">\n <a class=\"modal_link\"
title=\"405078_tumannost_krasnaya_xabbl_teleskop_1680x1050_(www.GdeFon.ru).jpg\"
data-toggle=\"modal-docked\" data-target=\"#configureblock\" href=\"#\"
data-blockid=\"83\" data-ar…itle=\"Download image
[www.imagesplitter.net](1).jpeg [19.2K]\"></span>\n <span
class=\"sr-only\">Download image [www.imagesplitter.net](1).jpeg
[19.2K]</span>\n </a>\n \n </li>\n \n </ul>\n </div>\n \n
\n</div>\n\n<script>\n jQuery('#configureblock .modal_link').off('click');\n
jQuery('#configureblock .modal_link').on('click', function(e) {\n
open_modal(e);\n toggleDetailsBtn();\n });\n</script>\n"
returnCode 0
** Attachment added: "correct gallery modal.png"
https://bugs.launchpad.net/mahara/+bug/1897829/+attachment/5415849/+files/correct%20gallery%20modal.png
** Changed in: mahara
Milestone: None => 20.10rc2
** Tags added: regression
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897829
Title:
20.10RC1: Choosing details in image gallery opens a blank modal
Status in Mahara:
New
Bug description:
Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme
Also exists in master on Ubuntu 18.10 and postgres with Ocean theme
Steps:
As a person with a page, add an image gallery with 5 images.
Save the page and display it.
Click the magnifying glass icon and the resulting details icon
Expected:
A modal appears with details of the image gallery block
Actual:
A blank modal appears
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897829/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
