The above patch fixes this instance of the bug, however there are
others.

Tested on Ubuntu 18.04
Firefox
Postgres 10.14
PHP 7.4
Raw and Primary School themes
Mahara 20.04_STABLE

Test steps:
1. Create a collection
2. On the 'Edit collection pages' page (collection/views.php) the 'Next: Edit 
access/ Cancel' button group has incorrect styling.
(It has "btn-primary submitcancel" classes, but is missing "btn" class.)
3. Load a second instance of Mahara with the fix. 
Results:
✔ On the collection/views.php page the styling is correct.
✔ Checking the inspect window shows "btn" class is now present.
PASSED.

4. Load 'Primary school' theme.
5. Click on 'Manage' for collection from P&C page.
Results:
✔ Styling is correct.

6. Look for other instances of "btn-primary submitcancel" without "btn" class
7. Check those for incorrect styling.
Results:
More incorrect styling found. See bug #tbc

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898955

Title:
  Add collection process missing button styles

Status in Mahara:
  Fix Committed

Bug description:
  This not a problem in 20.10+

  But is a problem in 20.04
  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898955/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to