Reviewed: https://reviews.mahara.org/11364 Committed: https://git.mahara.org/mahara/mahara/commit/f1d45474d2315f3a74f04dde474561851a861e24 Submitter: Robert Lyon ([email protected]) Branch: 20.10_STABLE
commit f1d45474d2315f3a74f04dde474561851a861e24 Author: Octavio Jr <unknown> Date: Wed Oct 14 12:15:55 2020 +1300 Bug 1898762: Adjusting test for memcached servers Change-Id: I8a363b1da74f136533584a87178aab38371a910b Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit c6d9850f1915c390126f768c7cd6f65f9ad844c9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1898762 Title: Regression memcached servers Status in Mahara: Fix Committed Status in Mahara 19.10 series: Fix Committed Status in Mahara 20.04 series: Fix Committed Status in Mahara 20.10 series: Fix Committed Bug description: Analising mahara 20.04.1 I see and regression on here : https://github.com/MaharaProject/mahara/blob/20.04_STABLE/htdocs/auth/lib.php#L681 Instead of this if (empty($server_version[$host . ':' . $port])) { $is_configured = false; } It should be this : if (!empty($server_version[$host . ':' . $port])) { $is_configured = true; } I tried to configured a memcached server and had an erreur as settings memcacheservers weren't set. In the code since $is_configured is already false, we have to invert the logic to see if a server is configured or not. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1898762/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
