Looking at this I'm thinking the get_rgb_from_hex() function is being a bit slow and because it is called multiple times during the generate thumbnail for skins. So if on slower machines it could take longer than the 30sec timeout
-- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1906908 Title: Mahara 19.10 upgrade fails due to set_time_limit 30 seconds Status in Mahara: Triaged Bug description: When upgrading to 19.10.x (or higher), the hard-coded set_time_limit(30) in lib/db/upgrade.php is too short for one of the steps if you have a fair bit of data to get through: [DBG] a4 (lib/db/upgrade.php:1565) Fixing skins for new format options PHP Fatal error: Maximum execution time of 30 seconds exceeded in /path/to/mahara-19.10.5/htdocs/lib/skin.php on line 965 (We have database size 2.5GB, disk usage 351.4GB.) The only way I could get this to complete was to either run cli upgrade.php repeatedly, or patch upgrade.php to set_time_limit(300). It took nearly four minutes to complete, but with this setting it completed normally. This part of the upgrade process should probably be put into some kind of batch counted loop to fit into 30 second chunks. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1906908/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
