Reviewed: https://reviews.mahara.org/11414 Committed: https://git.mahara.org/mahara/mahara/commit/ddbe0e6053b7dd05ca6876d811d85bceb7a14034 Submitter: Lisa Seeto ([email protected]) Branch: master
commit ddbe0e6053b7dd05ca6876d811d85bceb7a14034 Author: Robert Lyon <[email protected]> Date: Fri Oct 30 14:22:11 2020 +1300 Bug 1902318: Behat screenshot changes The after step fail screenshot is now named based on feature file / step text + line number to make it easier to find Added a new feature step called And show me a screenshot named "X" which will save a screenshot to the dataroot behat/html_output/screenshot/custom/ directory This is useful to see snapshots at any point (not just fail), eg And show me a screenshot named "1" And I click on "XYZ" And show me a screenshot named "2" And I press "ABC" And show me a screenshot named "3" Change-Id: I3446dd57a2c79d14c0e52239ce188a22d8ff09c7 Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1902318 Title: Better options when it comes to making screenshots in behat Status in Mahara: In Progress Bug description: Currently there is some code for creating a screenshot on step failure but it's not very useful as it saves the screenshot to dataroot with the name of the scenario as a subdir and feature as the name of the image file but when a step fails the error output mentions the feature file and step line so it's hard to quickly work out what screenshot is for what failure. Changes I want to implement: 1) Get the step fail screenshot to be better named, eg have the name of the feature file path be the subdir, eg for social/delete_page_collection_group.feature it makes social__delete_page_collection_group and for the screenshot it makes have the text of the failed step and line number, eg IloginasUserBwithpasswordKupuh1pa_line48.png 2) Create a step in BehatGeneral so that we can force a screenshot as it's own step so we can get multiple screenshots during a feature so that we can see what is happening before a failure. Because the step will be named specifically for making a screenshot we will need to allow the passing in of a variable to save the screenshot as, eg And show me a screenshot named "One", And show me a screenshot named "Two" etc. 3) For Ubuntu allow the system to open up the screenshot in image viewer without stopping behat running so that whether it's a failure screenshot or specified screenshot step we get to view the images without needing to hunt for them in the dataroot To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1902318/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
