Reviewed: https://reviews.mahara.org/11501 Committed: https://git.mahara.org/mahara/mahara/commit/51c4aa8370f7882b654b6ab1660309ffa7abf59f Submitter: Robert Lyon ([email protected]) Branch: master
commit 51c4aa8370f7882b654b6ab1660309ffa7abf59f Author: Evonne <[email protected]> Date: Wed Dec 16 12:11:09 2020 +1300 Bug 1907719: Fix styling issues 1. Profile picture in sidebar is now always within the background colour even when there is a short name. 2. 'Tags' is not displayed in bold any more so as not to draw too much attention to it. 3. Removed all pull-right and pull-left classes and put in float-right or float-left instead (bootstrap legacy). 4. Fixed field outline colour in the configurable theme so that the same colour is now used everywhere. 5. Reviewed the use of outer-link and inner-link as they were not accessible. Rule: If it is a single link it can an outer-link so that the entire item is outlined on click (nicer visually), but if the item has other links within it then outer-link should not be used. 6. Removed outer-link hover background as some list items had it and some didn't. Rule: No hover background colour for items. behatnotneeded Change-Id: I737841f9bfe825c0a004951bb4b7c7c589ab019d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1907719 Title: 20.10 theme bugs Status in Mahara: Fix Committed Status in Mahara 20.10 series: In Progress Status in Mahara 21.04 series: Fix Committed Bug description: Profile block header with profile image needs to have a min-height so profile image clears within the space. Remove all Tag in bold, change to normal weight. Remove all pull-right and pull-left classes and put in float-right or float-left instead (bootstrap legacy). Fix outline colour in custom theme, need specific paths as it is css not scss in this case. Review use of outer-link and inner-link as they were not accessible. Rule is if it is a single link it can an outer-link so that the entire item is outlined on click (nicer visually), but if the item has other links within it then outer-link should not be used. Remove outer-link hover background as some list items has it and some don't. Rule is no hover background colour for items. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1907719/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
