Reviewed: https://reviews.mahara.org/11730 Committed: https://git.mahara.org/mahara/mahara/commit/07628f16f938b9b7552c249f47fe92108a2b1d37 Submitter: Robert Lyon ([email protected]) Branch: master
commit 07628f16f938b9b7552c249f47fe92108a2b1d37 Author: Doris Tam <[email protected]> Date: Thu Apr 29 17:05:49 2021 +1200 Bug 1926556: Social media icons - include FAIcons in Elasticsearch Social media icons that are FontAwesome did not appear in the search results for Elasticsearch. A check was missing for FontAwesome. - Renamed 'Social network' to 'Social media' on the 'Social media' tab in the 'Profile' for consistency - Made sure not to display the icon/note for deleted social media accounts - Logic order fix: check for favicon before giving it the default faicon for a custom social media account - Add Tumblr as a known social network to match social_profile switch cases match with getting social_link - Changed text in behat test Change-Id: I49939c4a7c70b3642415ae21e491d77868b060e7 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1926556 Title: Social media icons not appearing on elasticsearch (artefact) Status in Mahara: Fix Committed Bug description: My previous patch did not fix this entirely... so I've reverted them for a better fix with this bug in context. ($icon bug) A check to allow FontAwesome icons to appear not the elasticsearch results for social profiles. There are two types of icons that we display for social media profiles: FontAwesome and favicons. They need to be dealt with differently. The cause of this bug is from the previous addition of FAIcons to Mahara and forgetting to take social media icons into consideration. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1926556/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
