Reviewed: https://reviews.mahara.org/11875 Committed: https://git.mahara.org/mahara/mahara/commit/9ae952e327cb27bf813a1a0a1a941c04b0c020ff Submitter: Gold ([email protected]) Branch: master
commit 9ae952e327cb27bf813a1a0a1a941c04b0c020ff Author: Robert Lyon <[email protected]> Date: Tue Jul 27 08:47:59 2021 +1200 Bug 1937982: Making sure report downloads have unique names Fixed a problem where two reports had the same name and also made a change where the datestamp for the CSV file is added to the name in case browsers are caching them and so fetching cached one instead of newly generated one. Change-Id: Id0f4ae007dbc96aab76842a7ffae7acbf391d6af Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1937982 Title: Download button on reports page always downloads same file Status in Mahara: In Progress Status in Mahara 21.04 series: Confirmed Status in Mahara 21.10 series: In Progress Bug description: Description: When generating a report in /admin/users/statistics.php, clicking the 'Download' button always downloads a file containing the exact same data as the first report that was run. Steps to replicate: 1. Go to the Reports page and click Configure Report 2. Find a report that will generate some data e.g. 'Account details'. Select a date range and click Submit. 3. Click 'Download' at the bottom of the page - view the file and look at the contents, also note the total file size on your computer 4. Find a different report that will generate some data, find an appropriate date range and click Submit 5. Click 'Download' again and view the file Observed results: The second generated file has the exact same contents as the first one. It has the exact same filesize as the first also. Essentially the resulting file doesn't reflect the newly-run report in any way. It's as if the first file that is generated is held in cache and can't be overwritten by a new report. Expected results: The second generated file contains the results of the second report that was run Additional notes: This happens regardless of the date range and report type. You could select the same report and try generating two lots of results with different date ranges - the exact same file (the very first one) will still be downloaded. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1937982/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
