Reviewed: https://reviews.mahara.org/11948 Committed: https://git.mahara.org/mahara/mahara/commit/c317793cec495c9b435d769d22fec6c943c1ff94 Submitter: Robert Lyon ([email protected]) Branch: master
commit c317793cec495c9b435d769d22fec6c943c1ff94 Author: Doris Tam <[email protected]> Date: Tue Aug 24 15:07:42 2021 +1200 Bug 1940881 - CSSTidy customisation: Allow comments for selectors and properties in CSS. Bug 1384467 - This allows all comments of top of CSS selectors and all inline comments attached to CSS properties Change-Id: I131f9b14f092f02d78a06a7cd99b1a25577c9c12 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1384467 Title: CSS is not stripping out bad css attributes anymore Status in Mahara: Fix Released Status in Mahara 1.10 series: Fix Released Status in Mahara 15.04 series: Fix Released Bug description: If I add some custom CSS to a skin that has badly formed css it doesn't strip out the bad lines. eg: #footer { color: #deface; top:cat; width: 300px; odd:fellow; } It used to strip it down to leave the valid lines. eg: #footer { color: #deface; width: 300px; } This looks to have been broken with this patch https://reviews.mahara.org/#/c/3846/ Well not broken as such but the $preserve_css should be able to be set via either the site config or directly in the config.php file so that only sites that want to allow things like comments in the css can turn it on rather than it be on by default for the skins. It still strips out html tags - so that is good To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1384467/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
