Reviewed: https://reviews.mahara.org/11785 Committed: https://git.mahara.org/mahara/mahara/commit/8ecb545305246d0e85d9b3f4dab4f7816f4238e0 Submitter: Robert Lyon ([email protected]) Branch: master
commit 8ecb545305246d0e85d9b3f4dab4f7816f4238e0 Author: Doris Tam <[email protected]> Date: Mon May 17 16:38:06 2021 +1200 Bug 1873119: Exports: private comment switch HTML export - done PDF export - done Leap2a export - WIP - Add a switch to allow exporting private comments - Default to only export public comments - Added lang string for new switch - Add option for comment_options to have privatefeedback default true - Remove dead code Change-Id: Id0389a6586c27479a30f1ab425683c598592ff33 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1873119 Title: Artefact + general comments are they appearing in HTML / PDF exports Status in Mahara: In Progress Bug description: If they are appearing in HTML export in a modal then we need to get them to appear in PDF a different way (probably appended to the page comments) The HTML export area for comments is out of date, also which is used by the PDF also. The formatting needs to be updated. Additional to this, adding a switch to allow private-comment-free exports. To test this: 1. Create a page with multiple blocks 2. Make comments to the artefacts displaying in the blocks - using a combination of the 'details' view as well as adding private and public comments 3. Export the page with the 'Include comments' ON and 'Include private comments OFF' - ✅ CHECK when 'Include comments' is OFF, 'Include private comments' switch is disabled 4. ✅ EXPECT - none of the private comments in the PDF export at the base page where the page comments sit. 6. ✅ EXPECT - the artefacts comments do not appear on the HTML export and only the PDF export 7. Export the page again with 'Include comments' ON and 'Include private comments' ON 8. ✅ EXPECT - the private comments appear in the PDF export with a grey background To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1873119/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
