Reviewed: https://reviews.mahara.org/12180 Committed: https://git.mahara.org/mahara/mahara/commit/7dc2b4fc81ef7b8f1b30afa4ee170bbe7a848fdc Submitter: Robert Lyon ([email protected]) Branch: 21.10_DEV
commit 7dc2b4fc81ef7b8f1b30afa4ee170bbe7a848fdc Author: Gold <[email protected]> Date: Wed Oct 27 13:03:26 2021 +1300 Bug 1948744: Refactor deployment IDs in LTI Advantage * Renamed LTI 1.1 and LTI Advantage in the Webservices External App form * Made Deployment ID labels generic (Main, 1, 2) * Made the Main Deployment ID required * Removed requirements on Deployment ID's 1 & 2 * Added validation to ensure a Deployment ID isn't used more than once Change-Id: I4ef93c598fba20b4c28b24a2500a3bfad435f28e (cherry picked from commit 7a36b370f78b5d19961983a855ea8f7b631a28a7) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1948744 Title: LTI Advantage: Remove deep link required field Status in Mahara: Fix Released Bug description: This affects Mahara 21.10 only When you set up the LTI Advantage integration, there are three fields for deployment IDs: - Basic launch - NRPS - Deep link (portfolio list). Currently, either Basic launch or NRPS AND Deep link are required and can't take the same deployment IDs. Sometimes we only get one deployment ID though from the LMS. Since LTI doesn't really care which deployment ID is listed where (it's a convenience on the Mahara site to distinguish them if there are multiple deployment IDs, I suggest: - Remove the requirement for 'Deep link' to be filled in. - Give it the # so that either Basic launch, NRPS, or Deep Link need to be filled in. - Rename the first deployment ID option 'Basic Launch' to 'Main deployment ID'. Add the description: If your platform only has one deployment ID, use this field. - Rename 'NRPS' to 'Additional deployment ID 1'. Description: Enter an additional deployment ID if needed, e.g. if you want to use separate deployments for NRPS or deep links. - Rename 'Deep Link (portfolio list)' to 'Additional deployment ID 2'. Description: Enter an additional deployment ID if needed, e.g. if you want to use separate deployments for NRPS or deep links. And while we are changing lang strings, can you please change the following for the drop-down menu on /webservice/admin/oauthv1sregister.php. The string ID can stay the same: - 'LTI advantage integration' to 'LTI Advantage' - 'LTI integration' to 'LTI 1.1' To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1948744/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
