Reviewed: https://reviews.mahara.org/12127 Committed: https://git.mahara.org/mahara/mahara/commit/5bc1e5e972f89be679123d4087d683884716d162 Submitter: Robert Lyon ([email protected]) Branch: main
commit 5bc1e5e972f89be679123d4087d683884716d162 Author: Doris Tam <[email protected]> Date: Wed Aug 18 12:06:03 2021 +1200 Bug 1926247: Only send notification for one page for collections copied into a group Change-Id: Ib60c0adebf6caee03c5fb4b67704e12c4e0383fb -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1926247 Title: Group collection notifications are sent per page Status in Mahara: Fix Committed Status in Mahara 21.10 series: In Progress Status in Mahara 22.04 series: Fix Committed Bug description: When a collection is shared with a group, the members of the group are receiving a notification per page access. They should be getting a single notification for the entire collection. The number of notifications sent is related to the activity_queue table rows for that type and collection. For a personal portfolio, the rows are written when the pages are added to the collection on collection/views.php where we "Add pages to collection"- we make sure that if there is already a entry in the table that matches the type and the collection id we don't add any extra ones. Group portfolios seem to have a different workflow in that each individual page is added as a row to the table on creation and not just when it adds to a collection later on. This will need to be investigated to see where we can avoid adding extra rows to the table that will produce page access notifications instead of collection access notifications. Steps to test: 1. Log in as admin to a site with at least a few other accounts 2. Create a group (can be 'controlled' membership) and add some other accounts 3. Create a group page, then another and then add them to a collection 4. Set the access to all members of the group and save 5. Run the cron and receive the notifications Expected results: All members of the group receive one notification to the collection Actual results: All members receive notifications based on the pages within the collection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1926247/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
