Reviewed: https://reviews.mahara.org/12301 Committed: https://git.mahara.org/mahara/mahara/commit/9fda06bad68c097a1d08fbd74bcf3170632078c1 Submitter: Robert Lyon ([email protected]) Branch: main
commit 9fda06bad68c097a1d08fbd74bcf3170632078c1 Author: Doris Tam <[email protected]> Date: Tue Dec 14 14:02:28 2021 +1300 Bug 1954871: PHPStan Lv. 0 bugs in htdocs/lib/ These apply to the parents patches of this 3rd party plugins ignored Rules covered: - should return ... but return statement is missing - class references with incorrect case - Static call to instance method - Result of ... method ... (void) is used - Inner named functions are not supported by PHPStan - Access to an undefined property Notes on changes: - Based on mahara.php postinst -> return boolean - Deleted useless '@return updated DB' line - All the calls to the instance method were static so I changed the function type - Removing the variable assignment on methods that return void - Removing arguments from method definitions that have been around for more than 10 years and have never been used or referenced - Removing dead calls to undefined functions (probably removed over time) and not cleaned up - set_magic_quotes_runtime() is PHP 5.3 thing, and is deprecated now - log_error changed to log_warn as the function doesn't exist Change-Id: I2fdb02e88e304d9cbf768d373d754aad77135844 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1954871 Title: PHPStan Level 0 bugs excluding undefined variables Status in Mahara: In Progress Bug description: PHPStan Level 0 bugs excluding undefined variables (as someone else is looking into that) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1954871/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
