Reviewed: https://reviews.mahara.org/12385 Committed: https://git.mahara.org/mahara/mahara/commit/7caa8d794bac012c8c731ce4b596f96ebcf85b7f Submitter: Robert Lyon ([email protected]) Branch: 21.10_DEV
commit 7caa8d794bac012c8c731ce4b596f96ebcf85b7f Author: Dianne Tennent <[email protected]> Date: Tue Jan 11 14:39:56 2022 +1300 Bug 1953095: 'Submitted host' info for LTI submission Update event handler in the submit function in view.php to include 'externalhost' Adjust strings to be more generic to work with both LTI1.1 and 1.3 Change-Id: I80ab755447e8441dc4a30dc3af871eee47575c40 (cherry picked from commit 119c101fda0d281536bf459793dd2842e9da6947) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1953095 Title: 'Submitted host' info not displayed for pages submitted via LTI Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Committed Bug description: When a page is submitted to the LMS, e.g. Brightspace, via LTI Advantage, the 'submitted host' info is not displayed in the notification. It looks like this: --- From: System To: NAME This is to confirm that you submitted the page "Page title" successfully to the external host "" at 01 December 2021, 11:02pm. If you have any questions about this submission, please contact the group administrator. --- Whereas for a collection the URL is displayed: --- From: System To: NAME This is to confirm that you submitted the collection "Collection title" successfully to the external host "https://LMS-DOMAIN"; at 01 December 2021, 10:54pm. If you have any questions about this submission, please contact the group administrator. --- The collection has the 'submittedhost' line in the code: https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/collection.php#L1808 whereas the view does not: https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/view.php#L1759 It will need to be added. While making this change, it would be good to update the language string 'messageexternal' and replace 'If you have any questions about this submission, please contact the group administrator.' with 'If you have any questions about this submission, please contact your instructor.' To replicate: 1. Set up LTI Advantage in an institution. 2. Set up an activity in Brightspace. 3. As student, submit a page in one submission and a collection in another. 4. Check the notifications. In both cases, the external host URL should be mentioned in the notification and the 'If' sentence should point to the course administrator. ----------------------------------- When you submit a page or collection via LTI 1.1, the normal 'External tool' via Moodle, for example, the message is: --- This is to confirm that you submitted the {page|collection} "Title of Portfolio" successfully to the group ""Title of the course" - "Title of the activity"" at 12 January 2022, 4:47pm. If you have any questions about this submission, please contact the group administrator. --- Since this takes the general group submission string and doesn't seem to be able to differentiate between external host and group, we could make the string generic: --- This is to confirm that you submitted the collection "SubmissionsTesting8" successfully to the group '"Patch12338" - "SubmissionTesting8"' at 12 January 2022, 4:47pm. If you have any questions about this submission, please contact your instructor. --- Note the single quotation mark around the part that comes from the LMS, which needs to be escaped. You can't have two double quotation marks next to each other. 1. Set up LTI 1.1 in an institution. 2. Set up two regular 'External tool' activities in Moodle. 3. As student, submit a page to one activity and a collection to another. 4. Check the notifications. In both cases, the external host URL should be mentioned in the notification. Please also change the following string while in the file: $string["subject"] = 'Your submission of your %s was successful'; to $string["subject"] = 'Submission of your %s was successful'; String ID change is not needed as it is a small change only and translators might have already used better wording. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1953095/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
