Reviewed: https://reviews.mahara.org/12297 Committed: https://git.mahara.org/mahara/mahara/commit/4652c975fcdbc7228766ada737f4da81f33ba824 Submitter: Robert Lyon ([email protected]) Branch: main
commit 4652c975fcdbc7228766ada737f4da81f33ba824 Author: Doris Tam <[email protected]> Date: Wed Dec 8 16:55:44 2021 +1300 Bug 1950067: Fix string for requesting sb elses's comment be public Change-Id: I27d56a53efe631ffaaefa9e719bba0e5ac058708 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1950067 Title: Wrong language used when requesting sb else's comment to be made public Status in Mahara: Fix Committed Status in Mahara 21.10 series: Fix Committed Status in Mahara 22.04 series: Fix Committed Bug description: This is a regression introduced - I believe - in bug #1940800. When a portfolio author requests that a comment author make their comment public, the text still says 'This comment is private. The comment author requested that you make their comment public.' even though it should be 'This comment is private. You have requested that this comment be made public.' See number 7 in the screenshot at https://manual.mahara.org/en/21.04/portfolio/feedback.html To replicate: 1. Create a page as Learner, allow comments, and share the page with a Educator. Leave moderation on 'No'. 2. Educator logs in and leaves a private comment on the page. 3. Learner logs in and views the comment and clicks 'Make comment public'. The Learner sees 'You have requested that this comment be made public.' 4. The Educator logs in and views the page Expected result: The text below the comment now reads 'This comment is private. The portfolio owner requested that you make your comment public.' Actual result: Instead, it reads 'This comment is private. The comment author requested that you make their comment public.' which suggests that the comment author (Educator) asked to have the comment made public when it was actually the portfolio author (Learner). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1950067/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
