Reviewed: https://reviews.mahara.org/12081 Committed: https://git.mahara.org/mahara/mahara/commit/05584c369242146f02fc1380f91b03401f69e1a2 Submitter: Robert Lyon ([email protected]) Branch: main
commit 05584c369242146f02fc1380f91b03401f69e1a2 Author: Pramith Dayananda <[email protected]> Date: Thu Aug 24 14:17:13 2017 +1200 Bug 1649433: Resume, replace old fileupload field with filebrowser Notes from Pramith: @TODO: file uploader closes popup and does not refresh content - I fixed this but needs to be done in a nicer way The problem comes from the filebrowser pieform: when adding a new file, it call the callback js function of the form. In other places in mahara, this is fine because the forms didn't need to set the callback so it could be used by the filebrowser element. But in this page, the form sets the callback to be compositeSaveCallback Notes from Dianne: - Replaced 'attachments' key with 'filebrowser' key in employment and education history classes. This gets correct filebrowser working. - Fixed the 'Edit' button in 'Achievements' and 'Education and Employment' by updating js - Added employment and education callbacks to compositeSaveCallback Change-Id: I02f881ddde59e82dcc0e9e973195c557d9925bed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: mahara-contributors https://bugs.launchpad.net/bugs/1649433 Title: Consolidate "Add file" buttons Status in Mahara: Fix Committed Bug description: We use two different ways of adding files to a text box / resume sections etc.: One, which allows you to add files from both your Mahara storage and computer and another one only from the computer. The latter one is the older one and can still be found in certain places. We should consolidate the occurances to always use the new way of adding files to be more consistent. Best case in point: When you add a file to your education history, you get the old button. However, when you edit that entry, you get the new button (see attachment). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1649433/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
